feat: Summary section, footer, header simplification & integration#728
Open
scazan wants to merge 3 commits intosidebar-componentsfrom
Open
feat: Summary section, footer, header simplification & integration#728scazan wants to merge 3 commits intosidebar-componentsfrom
scazan wants to merge 3 commits intosidebar-componentsfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
scazan
force-pushed
the
sidebar-components
branch
from
e5b828f to
d7917a2
Compare
scazan
force-pushed
the
process-builder-integration
branch
from
19b2640 to
008a0d1
Compare
scazan
force-pushed
the
sidebar-components
branch
from
d7917a2 to
928852b
Compare
scazan
force-pushed
the
process-builder-integration
branch
from
008a0d1 to
5d80141
Compare
- Add SummarySectionContent with process stats and validation status - Add SummarySectionInner for validation status display - Add ProcessBuilderFooter with Back/Next/Launch buttons and progress bar - Add ProgressIndicator progress bar component - Simplify ProcessBuilderHeader to breadcrumbs + Sheet-based mobile menu - Add ProcessBuilderShell with SidebarProvider wrapper - Update ProcessBuilderContent with minor prop updates - Wire shell, header, footer in edit page - Add i18n keys across all 5 language files (en, es, pt, fr, bn) - Update e2e tests for sidebar button selectors Note: Requires add-sheet PR to be merged first (Sheet component from @op/ui/Sheet)
scazan
force-pushed
the
process-builder-integration
branch
from
5d80141 to
2d56dab
Compare
nourmalaeb
approved these changes
Mar 9, 2026
Collaborator
nourmalaeb
left a comment
nourmalaeb
left a comment
There was a problem hiding this comment.
Really nice! Tiny nits, nothing blocking
|
|
||
| import { useTranslations } from '@/lib/i18n'; | ||
|
|
||
| const GRADIENT = 'linear-gradient(to right, #3EC300, #0396A6)'; |
Collaborator
There was a problem hiding this comment.
This could be done using tailwind classes: bg-linear-to-r from-green-500 to-teal-500
Comment on lines
+80
to
+83
| <p className="text-base text-neutral-black"> | ||
| <span className="font-bold">{processName}</span>{' '} | ||
| {t('is missing information in order to go live.')} | ||
| </p> |
Collaborator
There was a problem hiding this comment.
Could use t.rich() here:
t.rich(
'<highlight>{processName}</highlight> is missing information to go live.',
{
processName,
highlight: (chunks) => <span className="font-bold">{chunks}</span>,
}
)
Comment on lines
+123
to
+126
| <span className="font-bold">{processName}</span>{' '} | ||
| {t( | ||
| 'is ready to go live. Launching your process will invite and notify participants.', | ||
| )} |
Collaborator
There was a problem hiding this comment.
Same as above. Just a nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SummarySectionContentwith process stats and validation status displaySummarySectionInnerfor per-section validation stateProcessBuilderFooterwith Back/Next/Launch buttons and progress barProgressIndicatorprogress bar componentProcessBuilderHeaderto breadcrumbs + Sheet-based mobile menuProcessBuilderShellwithSidebarProviderwrapperStack
This is PR 3 of 3 in the Process Builder sidebar refactor:
nav-architecture)sidebar-components) ← baseTest plan
pnpm w:app typecheckcreate-process-instance.spec.ts