Skip to content

Add min/max validation to NumberField with on-blur error state#729

Open
valentin0h wants to merge 1 commit intodevfrom
budget-field-error-state
Open

Add min/max validation to NumberField with on-blur error state#729
valentin0h wants to merge 1 commit intodevfrom
budget-field-error-state

Conversation

@valentin0h
Copy link
Collaborator

@valentin0h valentin0h commented Mar 9, 2026

  • Add minValue/maxValue props to NumberField with built-in on-blur validation and error display
  • Wire budget field to use maxValue={maxAmount} and minValue={0} for immediate feedback

Caveats:

  • Not dealing with i18n in this PR because we haven't settled on a strategy yet.

@vercel
Copy link
Contributor

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview Mar 9, 2026 11:28am

Request Review

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Mar 9, 2026

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
[chromium] › tests/
decisions.spec.ts:6:3 › Decisions › can submit a proposal from decision page
View Logs
[chromium] › tests/
onboarding.spec.ts:23:3 › Onboarding › skips invites when none pending ─────
View Logs
[chromium] › tests/
onboarding.spec.ts:47:3 › Onboarding › shows invites when pending, accepts and proceeds
View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant