Use proposal profile name for titles#741
Open
valentin0h wants to merge 4 commits intoproposal-with-profile-for-all-endpointsfrom
Open
Use proposal profile name for titles#741valentin0h wants to merge 4 commits intoproposal-with-profile-for-all-endpointsfrom
valentin0h wants to merge 4 commits intoproposal-with-profile-for-all-endpointsfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Profile is now guaranteed by the encoder (non-optional), so optional chaining is unnecessary and hides potential issues.
valentin0h
force-pushed
the
proposal-title-vs-profile-name
branch
from
d6fcd4c to
2214e4d
Compare
valentin0h
changed the base branch from
dev
to
proposal-with-profile-for-all-endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile.nameas the proposal title source