[FIX] website_membership_registration: Update _check_mail_unique to use sql query instead of search to avoid maximum recursion depth issue

[ByteMeAsap]

No description provided.

[Copilot]

Pull request overview

Updates the website_membership_registration email uniqueness constraint to avoid recursion by replacing an ORM search() with a direct SQL query when checking for existing member partners.

Changes:

• Reworked _check_mail_unique to use cr.execute() against res_partner for the “existing member” email check.
• Kept the “existing user login” uniqueness check via ORM search.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The SQL condition email ILIKE %s treats % and _ in the provided email as wildcards (e.g., underscores are common in emails). That can cause false positives compared to Odoo's =ilike domain operator (which escapes wildcards for exact matching). Consider switching to an equality-based comparison such as LOWER(email) = LOWER(%s) (or explicitly escaping LIKE wildcards and adding an ESCAPE clause) to preserve exact-match semantics.

Suggested change

	WHERE email ILIKE %s
	WHERE LOWER(email) = LOWER(%s)

[Copilot]

This direct SQL query bypasses Odoo's usual active_test filtering. Previously, self.search(...) would (by default) ignore archived partners, but the SQL will match inactive records too, potentially blocking reuse of an email that only exists on an archived member. If the old behavior is desired, add an AND active (or equivalent) predicate to the SQL to align with the ORM search semantics.

Suggested change

	AND membership_state != 'none'
	AND membership_state != 'none'
	AND active