Skip to content

fix: close filesystem authority startup race - #433

Merged
NWYLZW merged 2 commits into
mainfrom
codex/fs-authority-startup-readiness
Aug 30, 2026
Merged

fix: close filesystem authority startup race#433
NWYLZW merged 2 commits into
mainfrom
codex/fs-authority-startup-readiness

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix the macOS filesystem asset-authority startup race: a trusted local request arriving during recovery is retained until the authority is ready, then handled with its original bounded input.
  • Requests that time out or encounter terminal recovery failure are closed fail-closed and cleaned up.

Root cause and fix

The local authority endpoint began accepting connections before recovery completed, so an initial asset operation could lose the startup race. The broker now retains only verified local pending connections during that narrow readiness window, enforces a bounded buffer, and either starts their session after recovery or closes them on timeout or recovery failure.

Changelog

  • changelog/1.0.0-rc.5/fs-authority-native.md

Screenshots

Not applicable — no user-interface surface changed.

Validation

  • pnpm -C packages/fs-authority-native test:native — 23 passed.
  • pnpm dprint check — passed.
  • pnpm exec eslint . — passed.
  • pnpm typecheck — passed.
  • Hosted CI must pass the real arm64 packaged authority smoke and macOS installer required gate before merge.

Review Scope

  • Risk: high
  • Applicable profiles: Desktop and dual-runtime paths; native authority startup concurrency.
  • Evidence: independent review rounds: the initial review’s sole P3 cleanup finding was resolved; the final incremental review found P0–P3: none; targeted tests cover readiness, timeout cleanup, and terminal recovery failure.
  • Rule exceptions: none.

Experience Review

  • 已判断是否需要沉淀经验
  • 如需要,已运行 $post-task-experience-review
  • reviewer PASS / NOT APPLICABLE 后才进入 merge

Experience Review Result: PASS. The accepted cleanup feedback reinforces existing fail-closed authority, readiness, and resource-lifecycle review requirements; it does not establish a new stable rule, so no rules change is proposed.

Policy Conflict Review

Not applicable — no workflow, permission, or release-rule documentation changed.

@NWYLZW
NWYLZW requested a review from a team as a code owner August 30, 2026 17:24
@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
oneworks-dev Ignored Ignored Preview Aug 30, 2026 5:40pm

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience Review

Before merge, make sure the PR body contains this completed checklist:

## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 merge

Checklist to confirm:

  • Decide whether this PR produced reusable project experience.
  • If experience should be captured, run $post-task-experience-review.
  • Merge only after the independent reviewer reports PASS or NOT APPLICABLE for the Experience Review Result.
  • For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

@NWYLZW
NWYLZW added this pull request to the merge queue Aug 30, 2026
Merged via the queue into main with commit c759e82 Aug 30, 2026
45 of 46 checks passed
@NWYLZW
NWYLZW deleted the codex/fs-authority-startup-readiness branch August 30, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant