test(web): preserve safe custom-element attribute defaults - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@oneworks/avatar-webcustom-element attribute boundary.system, unsupported editor locales fall back toen, boolean attributes preserve HTML presence semantics, and validdarktheme propagates.Why this is safe
This is a source-only safety-boundary regression in the Web Components adapter. The change is one regular
packages/test file; no CI trust-boundary, evidence verifier, deploy, npm, version, lockfile, generated asset, or documentation file is changed.Hosted reuse canary
The PR must receive the normal full Avatar SDK CI validation and produce its exact integration-tree evidence artifact. If this exact integration tree is squash-merged without base/tree/first-parent drift, protected main may reuse that artifact as
reused-pr-ci. Direct/manual events, trust-file changes, tampered evidence, and identity/tree/parent mismatches must remain full or fail-closed.No hosted workflow or production reuse result has been observed yet; this PR body does not claim one.
Validation
pnpm exec vitest run packages/web/__tests__/elements.spec.ts packages/web/__tests__/lifecycle.spec.ts packages/web/__tests__/pickers.spec.tspnpm exec vitest run __tests__/prCiEvidence.spec.tspnpm typecheckgit diff --checkReview scope
mainatd0b7936873f0e855b1724577b771196450218c9abefore branch creation.reused-pr-ci, and Deploy Avatar exact-SHA success.