Repository navigation
fix(logs): improve file display and support long path filters - #482
Merged
Merged
Conversation
Show log basenames with full-path inspection and copy actions, using the existing field styles. Normalize Loki filenames and accept file paths up to 4096 bytes in scoped and field filters. Add regression coverage and document adjacent-element consistency checks.
Member
Author
|
@codex review Please review the current head for correctness and regressions in log filename display, full-path inspection/copy, Loki filename normalization, and long file-path filtering. Pay particular attention to preserving source IDs, query escaping and limits, and keyboard accessibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Log files can have long directory paths, but the log viewer hid the file field by default and file filters rejected paths longer than 256 bytes. This change shows the basename by default, exposes the full path on hover and in a keyboard-accessible copy popover, and accepts file paths up to 4096 bytes.
filenamemetadata into the canonicalfilefield and support existing filename aliases in the UI.Validation
git diff --check.go test -race ./internal/pkg/logquery ./internal/manager/biz/logs ./internal/manager/server/logs.npm run lintstill reports 9 errors and 43 warnings in unchanged files.go test ./...against the committed source snapshot in a non-root Linux container. macOS cannot compile the existing Linux-only Edge code.Risk and rollback
No schema, collector configuration, source-ID, or dependency changes. File values remain bounded and retain existing query escaping and count limits. Revert this commit to restore prior behavior. Local test deployment backups are retained; the test deployment is not a production release.
Author confirmation