Add shared Makefile used by all components#3
Conversation
tameware
left a comment
There was a problem hiding this comment.
I love it! I'm a big fan of DRY.
I have not tested this. I don't know whether our existing deploy process is working - that makes me less inclined to try a new one.
| release: push | ||
|
|
||
| .dockerignore: .gitignore | ||
| sed 's#^[^/]#**/\0#' < $< > $@ |
There was a problem hiding this comment.
Please add a comment as to what's going on here.
A shared Makefile aims to remove duplicated image build and deployment targets from each component. Avoiding duplicate Makefile targets makes it easier to maintain a working deployment. Signed-off-by: Pauli <suokkos@gmail.com>
This is based on @kiat-huang 's changes which managed to deploy to production. I don't know if my deployment code works because docker push returns Access denied. I added some comments to the Makefile. |
|
I create a personal cluster. My cluster isn't exact copy of production because terraform failed with a permission error. I have no idea how terraform can fail when it should be using service account with same privileges as I have. I used Makefile to deploy dds ( To me it seems like deployment mostly works. |
A shared Makefile aims to remove duplicated image build and deployment
targets from each component. Avoiding duplicate Makefile targets makes
it easier to maintain a working deployment.
I created an example branch how to use the shared makefile in DDS service. I also pushed an annotated tag which makes
git describeoutput more than just a commit hash for version.https://github.com/suokko/DDS-1/tree/shared_makefile