Conversation
Track included API and Vibe Code allowances alongside separate pay-as-you-go spend. Support automatic browser-session import and manual cookies, with browser-folder access through the macOS menu bar. Add dashboard and menu bar reporting, configurable PAYG visibility, source-partitioned history, retention, and stale-data indicators. Handle partial endpoint failures without interrupting working allowance polling, and apply SQLite pragmas to pooled connections. Include regression tests and setup documentation.
Codecov flagged 0% coverage on readMistralSafariScopes, the hand-rolled Cookies.binarycookies parser, and on the Mistral tracker's Process/onReset path. Adds a synthetic binary-cookie fixture builder to exercise the parser's bounds checks (truncated/malformed input must fail closed with ErrMistralAuth) plus tracker, MistralCycleOverview, and CookieNames tests.
watchBrowserAccess listed Chrome/Edge/Firefox data folders every 2 minutes and could show "Grant Browser Access..." for every tray user, regardless of whether Mistral was enabled. Adds an explicit mistral_enabled flag to the menubar snapshot (a provider card only appears there after its first successful poll, so checking for a mistral card would hide the grant item exactly when it's needed) and gates the probe on it.
# Conflicts: # README.md
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
|
Thanks @sgogriff, this is merged to main via fast-forward (your three commits kept as authored: 3d9de6a, b89b1e6, df7419d), so closing the PR here. The retry state machine, the sanitized diagnostics and the native bridge origin checks were solid. We added four small commits on top:
Appreciate the thorough tests, they made the follow-ups easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #138. Browser-access failures could leave Mistral showing stale usage until a long backoff elapsed, even after access was granted. This PR fixes this and adds UI controls for users.
Changes
Validation
./app.sh --testrace suite passed before and after merging current upstream main.go vet ./...and production./app.sh --buildpassed on the merged code.GOFLAGS='-tags=menubar,desktop,production,granttest -run=TestBrowserGrant|TestMistral|TestAgentManager|TestMenubar' ./app.sh --test