Fix onnx-tf CI: pin pytest<9 for Python 3.8 compatibility#121
Open
andife wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
The onnx-tf stable and development Dockerfiles use
ubuntu:20.04, which ships with Python 3.8. Since PR #117 bumped the sharedrequirements_report.txttopytest>=9.0.3, both jobs have been failing at Docker build time — pytest 9.x dropped Python 3.8 support and is simply not available for it.Fix
Instead of using the shared
requirements_report.txtin the onnx-tf Dockerfiles, install the three dependencies inline withpytestpinned to>=8.0,<9(latest: 8.3.5). This keeps the shared requirements file unchanged so all other runtimes (Ubuntu 22.04/24.04, Python 3.10+) are unaffected.Test plan
onnx_tf_stableandonnx_tf_devDocker build steps pass in CI🤖 Generated with Claude Code