Skip to content

Allow float bias with Conv QDQ node group #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qti-ashimaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow float bias with Conv QDQ node group #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions onnxruntime/core/providers/qnn/qnn_ep_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ bool OrtConvNodeGroupSelector::Check(const OrtGraph* graph, const OrtApi& ort_ap
const OrtNode* redundant_clip_node,
const std::vector<const OrtNode*>& dq_nodes,
const std::vector<const OrtNode*>& q_nodes) const {
if (!CheckQDQNodes(graph, ort_api, node, redundant_clip_node, dq_nodes, q_nodes)) {
if (!CheckQDQNodes(graph, ort_api, node, redundant_clip_node, dq_nodes, q_nodes, static_cast<int>(dq_nodes.size()))) {
return false;
}

Expand All @@ -736,7 +736,8 @@ bool OrtConvNodeGroupSelector::Check(const OrtGraph* graph, const OrtApi& ort_ap
}
}

if (dq_nodes.size() == 3) { // has bias
if (dq_nodes.size() == 3) {
// Bias has a DQ node: it must be INT32.
auto dt_bias = GetNodeInputDataType(dq_nodes[2], ort_api, 0);
if (!dt_bias.has_value() || dt_bias.value() != ONNX_TENSOR_ELEMENT_DATA_TYPE_INT32) {
return false;
Expand Down
Loading