DO NOT MERGE YET: Don't included generated code in repo, generate on yarn install#9
Open
DO NOT MERGE YET: Don't included generated code in repo, generate on yarn install#9
Conversation
Contributor
|
CI is failed. Here is the CI workflow |
Collaborator
Author
|
Yeah I noticed that, not sure why it would fail as it's working fine locally. This isn't anything urgent, I'll try again to figure it out later. |
Contributor
Nope, it is not urgent but if the CI fails, the deployment might be failed as well. |
Collaborator
Author
|
Yeah to be clear I'm not suggesting we merge this until the CI passes, I'll update title to reflect that. |
AlexOnomy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the generated types from the git repository, adds them to git ignore and sets up package.json so they will be automatically generated on yarn install.
I have verified that the codegen command creates identical files to what is in the repo so there should be no functional impact to this change.
This change makes it less tempting to edit the generated code directly which would lead to issues later on if we had to regenerate. Better to treat these similar to build artifacts as they are derived from the ABIs that are still included in the repo.
This also cleans up the repo a bit which is always a good thing.