Repository navigation
calendar 0.1.2: views place events like the host Calendar view (#172) - #201
Merged
Merged
Conversation
Following the decision on atomic-server#1803 (#172): the data keeps the host's format with the exclusive End day, and the app's own Agenda and Week must draw every row on exactly the days the host table's Calendar view draws it. events.ts now places rows by Day, All day and End day, with the host's own isAllDayOnDate imported from the pinned browser/lib/src/calendar-date.ts, the way CalendarView.tsx buckets them: - all day with End day: Day <= day < End day (End day == Day, before Day or not a date: nowhere); - all day without End day, and every timed row: Day only, End day ignored; - no Day: nowhere. So a timed event that crosses midnight or spans days is drawn on its Day only (block capped at 24:00, labels give the real end), a timed event is placed by the date and clock of its stored offset rather than the viewer's zone, rows added with the host view's "+" (Day and End day, no Start or End) now show, untimed, and a Day or End day edited in the host table moves the event in the app too. The drawer no longer throws on a row without Start or End. The LocalThought lens (devonian/google-calendar/lens/projection.ts) failed the whole projection on an all-day event with end.date == start.date; it now reads it as one day with End day the day after, as project() does since #184. Unit tests check each case against the host's isAllDayOnDate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Built with `node integrations/tooling/apps.mjs write calendar`; 0.1.0 and 0.1.1 stay published unchanged. The catalog entry stays enabled: false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
changed the base branch from
claude/post-89-timesheets-issue-tracker
to
main
September 29, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172/#194, per Michiel's decision on ontola/atomic-server#1803: keep the host's existing calendar format (exclusive End day), and have the app's own views draw what the built-in Calendar view draws. Changing the built-in view is out of scope.
Stacked on #171 (base
claude/post-89-timesheets-issue-tracker). Merge after #171 lands; GitHub then retargets it to main.Placement. The app's Agenda and Week now place rows by Day, All day and End day using the host's own
isAllDayOnDate(imported frombrowser/lib/src/calendar-date.ts, not copied). Before, they placed rows from Start and End in the viewer's zone. Cases that changed:Lens.
devonian/google-calendar/lens/projection.tsthrew on an all-dayend.date == start.date. It now writes End day = the next day, the same #184 choiceadapter.tsalready makes.Decisions for Michiel (also in the README):
Release. The app becomes 0.1.2 (
apps/calendar/0.1.2/ui.js, 107,798 bytes). The catalog entry staysenabled: false.Checks run locally:
isAllDayOnDate) and e2e 4/4;apps.mjs check, certify, the e2e typecheck, oxfmt, and oxlint with 0 errors.The new placement is covered by unit tests only; no e2e has run it in a timezone other than Europe/Amsterdam.
🤖 Generated with Claude Code