Repository navigation
calendar 0.1.3: compare on open reads host Day/End day edits back to Google (#192) - #212
Merged
Merged
Conversation
Edits made to synced rows outside the app (the host's table, its Calendar view, another device) were already found on open for Name, Notes, Location, Start, End and All day. Edits to Day and End day were not: the next sync rewrote them from Start and End. hostValue() now reads the row's host format back through the lens (exclusive End day for all-day, Day's date with Start's clock and offset for timed), decided against the on-row baseline; what has no Google equivalent is held back and listed. Columns the app doesn't map are listed as kept here only. After a send, the row's Start and End are written from Google's answer. Release 0.1.3 (catalog entry stays enabled: false). Unit tests per case in app/compare.test.ts; the e2e edits End day as the user, reopens the app, reviews and sends it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-day labels (#192) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192: calendar compare-on-open. Edits made to synced event rows outside the app (the plain table, the built-in Calendar view, another device) become reviewed changes to send to Google.
What 0.1.2 already did. On open, the app compares every synced row with its on-row
sync-baseline. Name, Notes, Location, Start, End and All day edits already went to "Review N changes" and were sent withIf-Match: 412 means stale, a field changed on both sides is a conflict, and the baseline advances only after Google confirms.The gap fixed here. Day and End day edits made in the host were ignored and then overwritten from Start/End.
sync.tshostValue()now reads the host format back to Google (the lens inverse):Release: calendar 0.1.3 (
apps/calendar/0.1.3/ui.js). The catalog entry staysenabled: false. The #183 log hook is unchanged.Tests:
app/compare.test.tscovers every host-edit case: conflicts, a Google change to another field, local deletion, a hand-added row, and an unmapped column.view.test.tschecks the reopen shows "Review 1 change".PATCH {end:{date}}withIf-Match.apps.mjs check, tsc, oxfmt and oxlint are clean.Decisions for Michiel:
🤖 Generated with Claude Code