Skip to content

Durable afterCommit follow-ups (#1851 / #1906) #1907

Description

@michielbdejong

Left over from the durable afterCommit implementation (#1851, draft PR #1906), all behind --plugin-after-commit:

  • Uninstall or revoke: delete the app's afterCommit subscriptions (and the waiting proposals) when the app or Installation is uninstalled or revoked. Today they wait, like a paused installation.
  • Losing read access: end a subscription as soon as the person who activated it loses read access to the table. Today it ends at the next delivery attempt.
  • Stale proposals after a release change: refuse or discard a proposal that's waiting for review when the app's release changes. Today it's applied as reviewed.
  • Playwright spec (outside @smoke): add the view with Allow editing, edit a row in another tab, and check the hook's write lands; then the Read-only path produces a review bar.
  • Race test: a person's edit arriving just before the hook's write to the same row.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpluginShould probably be an Atomic Pluginserveratomic-server

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions