Skip to content

Keep context menus above the Android keyboard - #1631

Closed
joepio wants to merge 2 commits into
developfrom
codex/context-menu-keyboard
Closed

joepio wants to merge 2 commits into
developfrom
codex/context-menu-keyboard

Conversation

@joepio

@joepio joepio commented Sep 22, 2026

Copy link
Copy Markdown
Member

Changes

  • Reposition open dropdown and resource context menus on each visual viewport resize or scroll frame, so they follow the Android keyboard.
  • Limit menu height to the visible area and keep the action list scrollable above the keyboard.
  • Add a browser regression that simulates two keyboard animation steps and checks that the menu and its filter stay visible.

Validation

  • Data browser TypeScript: passed.
  • Focused lint and formatting: passed (existing lint warnings remain in Dropdown/index.tsx).
  • Browser E2E TypeScript: blocked by an unchanged ai-chat-discovery.spec.ts reference to missing Agent.aiChatsFolderSubject on develop.
  • Browser test and physical Android keyboard motion: not run locally; the app and server services were unavailable.

joepio added a commit that referenced this pull request Sep 30, 2026
# Conflicts:
#	browser/lib/src/client-db.ts
joepio added a commit that referenced this pull request Sep 30, 2026
…leViewTabs mock for useDriveApps' {apps, refresh} (#1904 x #1902), settle catalogs
@joepio

joepio commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Trekmeester: included in batch #1947 (run 36781515104; #1915 had been merged without it). It lands when that run is green; if this PR breaks something there, I take it out and say why here.

joepio added a commit that referenced this pull request Oct 1, 2026
… e2e traces, Android menus, demo tooling, docs (#1947)

Includes #1884, #1930, #1940, #1888, #1933, #1882, #1834, #1631, #1932, #1945 and the ForkBar part of #1530.

joepio commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Merged into develop through batch #1947 (squash 1f892aa); this head was verified as part of it. Closing.


Generated by Claude Code

@joepio joepio closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant