Repository navigation
Conversation
The message was the same for the status check, both start calls and both finish calls, and dropped the HTTP status. It now ends with the request and status, for example (/use/finish: 401).
Member
Author
|
Trekmeester: included in batch #1966 (run 36898843808). It lands when that run is green; if this PR breaks something there, I take it out and say why here. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: setting up an account passkey for recovery failed with "Could not set up your account passkey. Sign in to your account and try again." for every failure, so a report could not say which request was refused or why.
After: the message ends with the request and status, for example
(/use/finish: 401).The status check, both start calls and both finish calls share one error path in
accountPasskey.ts; it now addspath: statusto the text and keeps the existing wording in front.How: one template string plus a test that asserts the suffix. Found while chasing a report from atomic.place: the server side of these routes (
/api/passkeys/*) reads only the session cookie, not a device bearer token, and this change will confirm or rule that out.Requested by Joep