Repository navigation
Conversation
download-urls signs at most 64 objects per request, and restoreDrive asked for every object at once, so a drive with a longer history could not be restored on a new device.
This was referenced Sep 30, 2026
Merged
Member
Author
|
Landed on develop through the batch #1946 (squash f2a07aa), tested together on Mancave. Closing this PR since its commits are in that batch. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: opening a drive on a new device and pressing "Restore from Cloud Vault" failed with "at most 64 objects per download-urls request" once the drive's vault held more than 64 objects, so the drive could not be restored at all.
After: the restore asks for download URLs in batches of 64 and restores the whole vault, in listing order as before.
How:
restoreDriveinhelpers/managed/vault.tsnow requests/download-urlsin chunks ofDOWNLOAD_URL_BATCH(64, the control plane'sMAX_URL_BATCH) and merges the answers. A new test restores 150 objects, checks the batches are 64/64/22, and fails without the fix with the production error.Generated by Claude Code