Repository navigation
Conversation
A second tab signing in as a different account takes over the shared portal cookie. A backup pass the first tab already had in flight then reaches the control plane as that account and is told the enrollment does not exist, which was logged as a failed backup. When the signed-in account no longer matches the one the pass started for, it is now skipped quietly, like the 401 case.
Member
Author
|
Trekmeester: included in batch #1966 (run 36898843808). It lands when that run is green; if this PR breaks something there, I take it out and say why here. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: signing in as a different account in one tab, while another tab had a Cloud Vault backup running, logged "[cloud-vault] backup failed Error: Cloud Vault enrollment not found" in the old tab. This turned atomic-saas main red in
onboarding-existing-tab.After: when the signed-in account no longer matches the one the pass started for, the pass ends as "skipped: backup cancelled by account change", the same as the existing 401 case. Real failures still warn.
How:
ensureVaultBackupOnce's catch now checksaccountChangedSince(agent changed, no account session, or portal identity no longer matches) before warning. Two unit tests: the account-switch case is quiet (it fails without the change), and an unchanged account still reports the failure.Generated by Claude Code