Repository navigation
Conversation
…en if the PR list is unreadable Before: the dispatch token cannot list atomic-saas pull requests (403), so the open-PR check always failed and Downstream paired with any same-named saas branch, including a stale one left after its PR merged. Its old Cargo.lock then failed cargo --locked and turned the Main check red for a change that had nothing to do with it (#2114). After: when the PR list is unreadable, the commit's own PR list is asked next, which a token that can read the branch may also read. Only when both fail does the step pair with the namesake, as before, with the same warning.
joepio
added a commit
that referenced
this pull request
Oct 8, 2026
Combines #2123, #2127, #2133, #2134, #2135, #2136, #2138, #2140, #2141, #2142, #2143, #2147, #2149, #2132, #2121, #2129, #2146 and #1870. Includes fixes for the combination: Dagger mount for the form validation cases, drive mapping list without the flush sentinel, web_time in search, sidebar resize test at the touch bar height.
Member
Author
|
Landed on develop through the batch #2153 (d102056), with this PR's head unchanged. Closing as merged. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the Downstream job's "Pick the atomic-saas branch" step could never list atomic-saas pull requests, because the dispatch token gets a 403 ("Resource not accessible by personal access token"). Every failed lookup fell back to pairing with a same-named saas branch, so a stale branch left after its PR merged was built instead of main. Its old
Cargo.lockthen failedcargo --lockedand turned the Main check red for a change that had nothing to do with it (#2114, the wuchale key fix, closed and redone as #2118).After: when the PR list is unreadable, the step asks the commit's own PR list next (
commits/<branch>/pulls), which a token that can read the branch may also read, and only counts an open PR whose head is that branch. Only when both lookups fail does it pair with the namesake as before, with the same warning, so a branch that really adds dependencies is still not built against main by accident.How: one
||fallback in.github/workflows/main.yml. Checked by running the step script with the first lookup forced to 403: the staleclaude/project-thread-8tduponow builds main, an open PR's branch (codex/cloud-server-audit-20261006) still pairs, a branch without a namesake builds main, and with both lookups forced to fail the old warning and namesake pairing remain. Not verified: that the real dispatch token may call the commit endpoint; if it cannot, behaviour is unchanged and the real fix is giving the token "Pull requests: read" on atomic-saas (Joep's secret).Generated by Claude Code