Repository navigation
Conversation
Upload source maps per release when SENTRY_AUTH_TOKEN is set, so stacks name the real source instead of minified chunks. Set a hashed agent id as the Sentry user. Send drive, age, outbox size and connection state with 'Commit keeps failing'. Report Cloud Server setup failures that only showed a toast. Count repeats of an error per page load, so events lost to client-side dedupe still show their volume. Guard Bugsnag.notify with isStarted.
joepio
added a commit
that referenced
this pull request
Oct 8, 2026
Combines #2123, #2127, #2133, #2134, #2135, #2136, #2138, #2140, #2141, #2142, #2143, #2147, #2149, #2132, #2121, #2129, #2146 and #1870. Includes fixes for the combination: Dagger mount for the form validation cases, drive mapping list without the flush sentinel, web_time in search, sidebar resize test at the touch bar height.
Member
Author
|
Landed on develop through the batch #2153 (d102056), with this PR's head unchanged. Closing as merged. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: Sentry stacks pointed at minified chunks, the same error split into several issues by chunk hash, nobody could tell how many people an error touched, "Commit keeps failing" carried no drive or age, Cloud Server setup failures that only showed a toast left nothing behind, and an error raised ten thousand times arrived as one event.
After: stacks name the real source (when a build has a Sentry token), events carry an anonymous per-agent id, a failing commit reports its drive, age, outbox size and connection state, toast-only Cloud Server setup failures are reported, and an error that repeats 10, 100, 1000 … times on one page load sends a summary with the count. Bugsnag no longer logs "notify before start" on installs that don't use it.
Source maps are uploaded when
SENTRY_AUTH_TOKENis set in the build environment, then deleted so the binary does not grow. Without the token nothing changes: no plugin, no maps. A failed upload only warns and leaves the maps indist.How:
vite.config.ts:@sentry/vite-plugin(orgontola, projectatomic-browser, releaseatomic-data-browser@<version>+<commit>, same string the SDK reports), hidden maps,filesToDeleteAfterUpload.@sentry/clibuild script stays off inpnpm-workspace.yaml: the binary comes from the optional platform package.sentry.ts:identifyAgentInSentrysets the user to the first 8 bytes of the SHA-256 of the agent id (no email,sendDefaultPiistays off);countRepeatedEventsruns on the client'spreprocessEventhook, which fires before Dedupe, and is bounded to 200 tracked errors per page load;reportUserFacingFailurefor toast-only failures.store.ts:RepeatedCommitFailuregainsdrive,ageMs,outboxSize,connected,isGenesis,rearmedAfterResync. Fingerprints are unchanged.SyncRoute.tsx: three reports inbackupToCloud(no portal configured, failure after sign-in, automatic enrollment threw). The manual catch already goes throughstore.notifyError.Tests:
sentry.test.ts(18, counter, pseudonym, ordering, payload),loggingHandlers.test.ts. Built with and without a token: no token gives 0 source maps; a fake token tries the upload, warns and carries on.To turn on source maps, add
SENTRY_AUTH_TOKEN(release and source map upload scope) as a secret to every build that serves users.Requested by Joep