Repository navigation
Conversation
Store.search used to await the local OPFS index before firing the hosted /search request, so the two ran back to back. Start both at once, keep the merge/dedupe/destroyed filtering, and fall back to server results when the local search fails. New SearchOpts.onPartial reports local hits early; useServerSearch uses it to show them while loading stays true. The cmd+k overlay now shows a spinner and skeleton rows while searching, and the RTE @-suggestion list shows a Searching... row while items load.
joepio
added a commit
that referenced
this pull request
Oct 8, 2026
Combines #2123, #2127, #2133, #2134, #2135, #2136, #2138, #2140, #2141, #2142, #2143, #2147, #2149, #2132, #2121, #2129, #2146 and #1870. Includes fixes for the combination: Dagger mount for the form validation cases, drive mapping list without the flush sentinel, web_time in search, sidebar resize test at the touch bar height.
Member
Author
|
Landed on develop through the batch #2153 (d102056), with this PR's head unchanged. Closing as merged. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep · project thread
Before:
Store.searchawaited the local OPFS index before it sent the hosted/searchrequest, so on a large drive the request started late. The cmd+k panel and the @-resource list showed no clear loading state.After: the local and hosted searches start together. Local hits show immediately through a new
onPartialcallback while the hosted answer is pending. cmd+k shows a spinner and skeleton rows, and the @-list shows "Searching..." instead of "No results found".How:
Store.searchruns both searches concurrently and keeps the merge, dedupe and destroyed filtering. A failing local index no longer fails a search the server can answer. Two new tests instore-search-server.test.ts.Screenshots of the loading states are still to come (the sandbox had no browser).
🤖 Generated with Claude Code
https://claude.ai/code/session_0154iW1qSbFvWBajyADNezRi
Generated by Claude Code