Repository navigation
Conversation
The test fails on every CI run since batch #2210 and never locally: the visitor's Hi never appears, so Mara has nothing to answer. It now checks that the Hi posts before waiting for the greeting, and prints the page's console when either step fails, so the next CI run shows the cause.
The page console alone may not say why the visitor's Hi is missing in CI. The failure now also prints every chat entry on screen, the input's value, whether the store is connected, and what the outbox holds.
Member
Author
|
Closing: develop's demo-chat e2e has been green since the 30 s greeting wait (77a2e85) and the later demo fixes (#2230, #2233), so these extra diagnostics are not needed. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
demo-chat.spec.ts:24fails on every develop run since batch #2210 (runs 5205 and 5208, 6 of 6 attempts) with "Welcome to the team" not found. CI's page snapshot shows the visitor's own "Hi" never appears and the input is empty, so Mara has nothing to answer. The test passes locally 10 of 10, includingtest-e2e:local --same-originagainst develop's server, and the CI artifacts can't be downloaded from the agent sandboxes.After: the test first checks that the visitor's Hi shows up (15 s), then the greeting (5 s), and on either failure prints the page's console to the test output, so the next CI run shows where it stops.
How: a
consoleandpageerrorcollector on the page, printed from acatcharound the two assertions;toHaveValue('Hi')before Enter rules out a lost fill. No product code changes; this does not fix the red by itself.Related Issues
Develop red on demo-chat after batch #2210.
Checklist
Generated by Claude Code