Skip to content

fix(about): drop stale swift-markdown-ui acknowledgement#34

Merged
BlackHole1 merged 1 commit into
mainfrom
fix/drop-stale-markdown-ui-acknowledgement
Jun 24, 2026
Merged

fix(about): drop stale swift-markdown-ui acknowledgement#34
BlackHole1 merged 1 commit into
mainfrom
fix/drop-stale-markdown-ui-acknowledgement

Conversation

@BlackHole1

Copy link
Copy Markdown
Member

The app stopped depending on swift-markdown-ui once the update window began parsing release notes itself via AttributedString(markdown:), but the Acknowledgements sheet still credited it — showing users a library that ships nowhere in the build.

Remove the entry from the credits list and sync the two docs that described it: DESIGN.md's acknowledgements rundown and RELEASING.md's now-false claim that the update window renders with swift-markdown-ui (it uses its own parser).

The app stopped depending on swift-markdown-ui once the update window
began parsing release notes itself via AttributedString(markdown:),
but the Acknowledgements sheet still credited it — showing users a
library that ships nowhere in the build.

Remove the entry from the credits list and sync the two docs that
described it: DESIGN.md's acknowledgements rundown and RELEASING.md's
now-false claim that the update window renders with swift-markdown-ui
(it uses its own parser).

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01bc96c4-3568-480b-8407-3ad1ebd281d1

📥 Commits

Reviewing files that changed from the base of the PR and between f3b7191 and 442cf30.

📒 Files selected for processing (3)
  • Sources/LockIME/UI/AboutView.swift
  • docs/DESIGN.md
  • docs/RELEASING.md
💤 Files with no reviewable changes (1)
  • Sources/LockIME/UI/AboutView.swift

Summary by CodeRabbit

  • Bug Fixes
    • Updated the app’s acknowledgements list so it shows the correct set of included libraries.
    • Adjusted the About window’s license acknowledgements content to match the current dependencies.

Walkthrough

The swift-markdown-ui library is removed from the acknowledgements displayed in the About window. In AcknowledgementsView, its .init(...) entry is deleted from the libraries array. docs/DESIGN.md is updated to list PermissionFlow instead of swift-markdown-ui in the description of the acknowledgements sheet. docs/RELEASING.md is updated to state that the update window renders embedded markdown using the app's own parser rather than swift-markdown-ui.

Possibly related PRs

  • oomol-lab/LockIME#21: Also modifies the About-window acknowledgements and docs/RELEASING.md in relation to removing swift-markdown-ui/MarkdownUI references for release-notes parsing.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required type(scope): subject format and accurately reflects the stale acknowledgment removal.
Description check ✅ Passed The description is directly related to the code and docs changes, explaining the removed dependency credit and documentation updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/drop-stale-markdown-ui-acknowledgement

Comment @coderabbitai help to get the list of available commands.

@BlackHole1 BlackHole1 merged commit 411d2e0 into main Jun 24, 2026
3 checks passed
@BlackHole1 BlackHole1 deleted the fix/drop-stale-markdown-ui-acknowledgement branch June 24, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant