This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Remove unused Channel test case names#3232
Open
0xcharry wants to merge 1 commit intoop-rs:mainfrom
Open
Conversation
0xcharry
requested review from
BioMark3r,
einar-oplabs,
emhane,
op-will and
theochap
as code owners
Collaborator
|
These test case names seem very useful, even if not used. Instead of removing them, is there a way to instead use them such that failures report the specific test case that failed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the unused name field from FrameValidityTestCase, removing dead code and needless string allocations in channel tests. Keep test coverage identical while eliminating #[allow(dead_code)] and unused imports.