Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Chore(protocol): drop unused test case name field #3241

Closed
0xcharry wants to merge 1 commit into from
Closed

Chore(protocol): drop unused test case name field #3241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions crates/protocol/protocol/src/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ mod test {
};

struct FrameValidityTestCase {
#[allow(dead_code)]
name: String,
frames: Vec<Frame>,
should_error: Vec<bool>,
sizes: Vec<u64>,
Expand Down Expand Up @@ -258,14 +256,12 @@ mod test {
let id = [0xFF; 16];
let test_cases = [
FrameValidityTestCase {
name: "wrong channel".to_string(),
frames: vec![Frame { id: [0xEE; 16], ..Default::default() }],
should_error: vec![true],
sizes: vec![0],
frame_data: None,
},
FrameValidityTestCase {
name: "double close".to_string(),
frames: vec![
Frame { id, is_last: true, number: 2, data: b"four".to_vec() },
Frame { id, is_last: true, number: 1, ..Default::default() },
Expand All @@ -275,7 +271,6 @@ mod test {
frame_data: None,
},
FrameValidityTestCase {
name: "duplicate frame".to_string(),
frames: vec![
Frame { id, number: 2, data: b"four".to_vec(), ..Default::default() },
Frame { id, number: 2, data: b"seven".to_vec(), ..Default::default() },
Expand All @@ -285,7 +280,6 @@ mod test {
frame_data: None,
},
FrameValidityTestCase {
name: "duplicate closing frames".to_string(),
frames: vec![
Frame { id, number: 2, is_last: true, data: b"four".to_vec() },
Frame { id, number: 2, is_last: true, data: b"seven".to_vec() },
Expand All @@ -295,7 +289,6 @@ mod test {
frame_data: None,
},
FrameValidityTestCase {
name: "frame past closing".to_string(),
frames: vec![
Frame { id, number: 2, is_last: true, data: b"four".to_vec() },
Frame { id, number: 10, data: b"seven".to_vec(), ..Default::default() },
Expand All @@ -305,7 +298,6 @@ mod test {
frame_data: None,
},
FrameValidityTestCase {
name: "prune after close frame".to_string(),
frames: vec![
Frame { id, number: 0, is_last: false, data: b"seven".to_vec() },
Frame { id, number: 1, is_last: true, data: b"four".to_vec() },
Expand All @@ -315,7 +307,6 @@ mod test {
frame_data: Some(b"sevenfour".to_vec().into()),
},
FrameValidityTestCase {
name: "multiple valid frames, no data".to_string(),
frames: vec![
Frame { id, number: 1, data: b"seven__".to_vec(), ..Default::default() },
Frame { id, number: 2, data: b"four".to_vec(), ..Default::default() },
Expand All @@ -327,7 +318,6 @@ mod test {
frame_data: None,
},
FrameValidityTestCase {
name: "multiple valid frames".to_string(),
frames: vec![
Frame { id, number: 0, data: b"seven__".to_vec(), ..Default::default() },
Frame { id, number: 1, data: b"four".to_vec(), ..Default::default() },
Expand Down