This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(node/rpc): implement admin state persistence#3256
Open
Farukest wants to merge 1 commit intoop-rs:mainfrom
Open
feat(node/rpc): implement admin state persistence#3256Farukest wants to merge 1 commit intoop-rs:mainfrom
Farukest wants to merge 1 commit intoop-rs:mainfrom
Conversation
Implement the rpc.admin-state CLI flag functionality to persist admin API state changes (sequencer active/stopped, recovery mode) across node restarts. - Add AdminState struct with serde serialization support - Add AdminStatePersistence helper for loading/saving state to disk - Add admin_state_persistence field to SequencerActor - Persist state on start_sequencer, stop_sequencer, set_recovery_mode calls - Load persisted state on node startup if configured When --rpc.admin-state is set to a file path, the node will: 1. Load saved state on startup (if file exists) 2. Save state changes whenever admin API modifies sequencer state Closes op-rs#3124
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
--rpc.admin-stateCLI flag functionality that was defined but never implemented.When a file path is provided via
--rpc.admin-state, the node will:Changes
AdminStatestruct: Serializable struct containingsequencer_activeandrecovery_modefieldsAdminStatePersistencehelper: Providesload()andsave()methods for JSON file persistenceSequencerActor: Addadmin_state_persistencefield to handle persistencestart_sequencer,stop_sequencer, andset_recovery_modenode.rswhen initializing the sequencerPersisted State
{ "sequencer_active": true, "recovery_mode": false }Test plan
Closes #3124