Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust workspace to event-store v0.12.0, bumps rand to the 0.10 series, and adjusts rand usage/features to restore wasm32-unknown-unknown compatibility (avoiding getrandom-driven build failures on wasm).
Changes:
- Bump workspace version to
0.12.0and update workspace dependencies (randto0.10.2,tokioto1.53.1). - Rework
randusage incdk_runtimeto useStdRng/RngExtand target-specificrandfeatures to keep wasm builds working. - Update integration-test RNG helpers to the new
randdistribution module layout.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rs/utils/Cargo.toml | Enables serde derive via workspace dependency to support derives in this crate. |
| rs/producer/cdk_runtime/src/lib.rs | Updates RNG APIs for rand 0.10 and adjusts wasm vs non-wasm seeding logic. |
| rs/producer/cdk_runtime/Cargo.toml | Splits rand features by target to avoid wasm build issues while keeping host random() available. |
| rs/producer/agent_runtime/Cargo.toml | Enables rand feature(s) needed for rand::random() in the agent runtime. |
| rs/integration_tests/src/rng.rs | Updates distribution imports/bounds for rand 0.10 API changes. |
| rs/integration_tests/Cargo.toml | Enables rand feature(s) needed for rand::random() in integration tests. |
| rs/canister/CHANGELOG.md | Adds a changelog entry for v0.12.0 and references the PR. |
| Cargo.toml | Bumps workspace version and upgrades workspace rand/tokio dependency versions. |
| Cargo.lock | Updates lockfile for new workspace version and dependency upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Prevent potential out-of-bounds panic in wasm `rng_seed` by capping the canister id bytes at 24 and writing the timestamp into the final 8 bytes - Fix 0.12.0 changelog entry to link to the v0.12.0 tag and PR #103 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hpeebles
enabled auto-merge (squash)
July 20, 2026 19:57
julianjelfs
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.