refactor: restructure app components by platform and feature - #9085
Draft
ivan-jukic wants to merge 1 commit into
Draft
refactor: restructure app components by platform and feature#9085ivan-jukic wants to merge 1 commit into
ivan-jukic wants to merge 1 commit into
Conversation
Replace components/, components_mobile/ and components_shared/ with desktop/, mobile/ and ui/ trees, each split into features/ (chats, chatlist, bots, profile, wallet, ...), shared/ and shell/. Placement was computed from the import graph: a component lives with its only consumer feature, in shared/ when consumed by several, in src/ui when consumed by both platforms (flagged in ui/STRAGGLERS.md for review). Deletes 33 files nothing imports and adds an eslint boundary rule (desktop and mobile never import each other; features are private except exports/ and chats/core). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MvT4UYdWURffYxsCHowXFy
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
frontend/app/src/{components,components_mobile,components_shared}with:Features:
chats/umbrella (core= kind-agnostic message engine,thread,pinned,group,community,members), pluschatlist,bots,profile,wallet,access,proposals,onboard,landing, etc. Same taxonomy in both platform trees.@shared_componentsalias removed (vite + tsconfig)local/structure-boundaries:desktop/↛mobile/(either direction),src/ui↛ platform treesexports/(e.g.bots/exports/BotBadge.svelte) orfeatures/chats/core/**; 149 pre-existing violations are the baseline to burn down, then flip to errorHow placements were decided
Computed from the import graph, not by hand: a component lives with the only feature that imports it; multi-feature consumers → platform
shared/; consumers in both trees →src/ui+ entry inui/STRAGGLERS.md; no importers → deleted. Human input was a 33-entry seed map (panel roots and Home-mounted modals whose only importer is the shell) and the folder→feature mapping.Verification
svelte-check: 4716 files, 0 errorseslint: 0 errors (152 warnings: 149 boundary baseline + 3 pre-existing)vitest: 372/372git log --followtraces history through the renamesFollow-ups (not this PR)
ui/STRAGGLERS.md— promote or fork per platformdesktop/shell/Home.svelte:450, case fallthroughchats/core/PreviewFooter.svelte:103, async promise executorprofile/ViewUserProfileModal.svelte:69🤖 Generated with Claude Code
https://claude.ai/code/session_01MvT4UYdWURffYxsCHowXFy