Skip to content

feat: sign gro darwin binaries with a stable code-signing identity #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 3 commits into from
Jun 3, 2026
Merged

feat: sign gro darwin binaries with a stable code-signing identity #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc4e382
feat: sign gro darwin binaries with a stable code-signing identity
rianjs Jun 3, 2026
d4cd180
docs: correct stale 'unsigned' cask comment now that gro is signed
rianjs Jun 3, 2026
d11897f
fix: make the darwin codesign hook fail loud on a broken script
rianjs Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@ jobs:
chocolatey-api-key: ${{ secrets.CHOCOLATEY_API_KEY }}
winget-token: ${{ secrets.WINGET_GITHUB_TOKEN }}
linux-dispatch-token: ${{ secrets.LINUX_PACKAGES_DISPATCH_TOKEN }}
macos-cert-p12: ${{ secrets.MACOS_CERT_P12 }}
macos-cert-password: ${{ secrets.MACOS_CERT_PASSWORD }}
macos-cert-cn: ${{ secrets.MACOS_CERT_CN }}
macos-cert-leaf-sha: ${{ secrets.MACOS_CERT_LEAF_SHA }}
10 changes: 9 additions & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ builds:
- -X github.com/open-cli-collective/google-readonly/internal/version.Version={{.Version}}
- -X github.com/open-cli-collective/google-readonly/internal/version.Commit={{.Commit}}
- -X github.com/open-cli-collective/google-readonly/internal/version.Date={{.Date}}
# macOS code-signing — stable DR so Keychain "Always Allow" survives brew upgrade
# (cli-common distribution.md §2A). Logic + identity live in open-cli-collective/.github
# (macos-codesign-setup), which exports CODESIGN_DARWIN_SCRIPT (absolute). Unset in
# local builds → signing skipped.
Comment thread
monit-reviewer marked this conversation as resolved.
hooks:
post:
Comment thread
monit-reviewer marked this conversation as resolved.
Comment thread
monit-reviewer marked this conversation as resolved.
- cmd: bash -c 'f="${CODESIGN_DARWIN_SCRIPT:-}"; if [ -z "$f" ]; then echo "skip codesign (CODESIGN_DARWIN_SCRIPT unset, local build)"; exit 0; fi; [ -x "$f" ] || { echo "CODESIGN_DARWIN_SCRIPT not executable ($f)" >&2; exit 1; }; exec "$f" "$0" "$1"' "{{ .Path }}" "{{ .Os }}"
- id: gro-unix-win
main: ./cmd/gro
binary: gro
Expand Down Expand Up @@ -94,7 +101,8 @@ nfpms:
- src: LICENSE
dst: /usr/share/licenses/google-readonly/LICENSE

# Canonical Homebrew cask with auto-quarantine removal for unsigned binaries.
# Canonical Homebrew cask with auto-quarantine removal for non-notarized binaries
# (the darwin binary is code-signed per cli-common distribution.md §2A, not notarized).
# skip_upload: true → goreleaser RENDERS the cask into dist/ but does NOT push
# it; the reusable release workflow's homebrew step is the single atomic tap
# writer. No `token:` here — the tap token belongs only to that writer, and
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0
1.1
Loading