Sync shared figure tooling to its final revision - #128
Merged
Conversation
Re-copy docs/figures/{palette,make_family}.py from the launch programme's shared
source (byte-identical, sha256 verified) and rename make_surfaces.py's unused
render() theme-name parameter to _name to match. Tighten the docs/figures
per-file-ignores in pyproject.toml to the exact named PLR0913/PLR0917/T201 codes
still needed now that the shared files fixed their own FBT003/ARG001 findings --
no blanket exclude, so a real bug in either shared file still surfaces here.
Every regenerated figure is byte-identical to what was already committed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
jothimani-rajendran
marked this pull request as ready for review
September 9, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #126, which merged before the launch programme's shared figure tooling
reached its final revision. Brings
docs/figures/make_family.pyto the sha25694a9f5d8ba9c76d4ce582e2a26d5f2f272ad31554c3e30d7b8c121b84c1ee9f9now committedbyte-identically in the other three open-coder-ai repos (
docs/figures/palette.pywas already at its final
3d31c144...revision onmain). Renamesmake_surfaces.py's unusedrender(t, name)parameter to_nameto match the samefix upstream, and tightens the
docs/figuresper-file-ignores inpyproject.tomltothe exact named
PLR0913/PLR0917/T201codes still needed now that the sharedfiles resolved their own
FBT003/ARG001findings -- no blanket exclude, so a realbug in either shared file (an undefined name, an unused import) would still surface
in this repo's own lint.
Every regenerated figure (
docs/figures/*.svg,social-card.png) is byte-identicalto what
mainalready has;git diff --exit-code -- docs/figuresis clean afterregenerating from these files.
Definition of done
chock check-- fails today only on a pre-existing vendored-runtime driftunrelated to this PR (see Add generated theme-aware figures (block 2) #126's description for the
git stash-verified proof)pytest -q-- 1136 passed, 2 skipped, the same 2 pre-existing failures asmainruff check .andruff format --check .cleanClaims
ignores.
INSTALLED_SURFACESand the coverage table are untouched.🤖 Generated with Claude Code