fix: use ldflags for version injection instead of hardcoded 1.0.0#16
Merged
Conversation
The --version flag and SARIF driver version were hardcoded to "1.0.0", causing ods@v0.2.1 to report the wrong version. Replace both with a version.Value variable that is set via -ldflags at build time and defaults to "dev" for development builds. Example: go build -ldflags="-X github.com/open-delivery-spec/cli/internal/version.Value=v0.2.1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ods --versionalways outputsods version 1.0.0regardless of the actual release version (e.g., v0.2.1). This happens because the CobraVersionfield and the SARIF driver version are hardcoded to"1.0.0".Fix
internal/version/version.go— declaresvar Value = "dev"that can be overridden via-ldflagsinternal/cmd/root.go—Version: version.Valueinstead ofVersion: "1.0.0"internal/report/report.go— SARIF driver version usesversion.Valueinstead of"1.0.0"Build command
go build -ldflags="-X github.com/open-delivery-spec/cli/internal/version.Value=v0.2.1" ./cmd/ods/ods --versionnow correctly showsods version v0.2.1. Without ldflags, it showsods version dev.Verification