fix: make websocket cleanup cancellation-safe - #20
Merged
typefield merged 3 commits intoJul 30, 2026
Conversation
|
CR 结论:LGTM,未发现本 PR 引入的阻断项。 已核对提交 本地验证(macOS / Node 22.15.0):
GitHub CI:6/6 通过。 非阻断 follow-up:当前生产依赖的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
在已合并 #17 的重连风暴修复之上,补齐连接清理、handler 背压、重复消息和包兼容性问题:
LATERAsyncLocalStorage写回来源 socketoff(topic, originalCallback)继续有效Related issues and PRs
Closes #12.
Refs #13.
Closes #16.
Closes #18.
Follow-up to #17; also covers the async handler use case from closed/unmerged #9.
Validation
npm test、npm run typechecknode --trace-warnings test/lifecycle-mock.mjsactionlint、git diff --check