Skip to content

chore(tests): store instance segmentation accuracy results in native format#613

Merged
tybulewicz merged 1 commit into
masterfrom
ttybulew/test_instance_segmentation_results
Jun 29, 2026
Merged

chore(tests): store instance segmentation accuracy results in native format#613
tybulewicz merged 1 commit into
masterfrom
ttybulew/test_instance_segmentation_results

Conversation

@tybulewicz

@tybulewicz tybulewicz commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the accuracy test framework to serialize and compare InstanceSegmentationResult outputs in a structured (native JSON) format rather than the previous string-based representation, aligning instance-segmentation accuracy baselines with other result types.

Changes:

  • Added structured dump + comparator utilities for InstanceSegmentationResult (objects + contours).
  • Refactored contour comparison into a shared assert_contours_match helper.
  • Regenerated public_scope.json instance-segmentation references to the new JSON schema.

Fixes #599

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@tybulewicz
tybulewicz requested a review from Copilot June 26, 2026 06:39
@tybulewicz
tybulewicz requested a review from a team as a code owner June 26, 2026 06:39
@github-actions github-actions Bot added the tests Related to tests label Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the accuracy test framework to serialize and compare InstanceSegmentationResult outputs in a structured (native JSON) format rather than the previous string-based representation, aligning instance-segmentation accuracy baselines with other result types.

Changes:

  • Added structured dump + comparator utilities for InstanceSegmentationResult (objects + contours).
  • Refactored contour comparison into a shared assert_contours_match helper.
  • Regenerated public_scope.json instance-segmentation references to the new JSON schema.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
model_api/tests/accuracy/test_accuracy.py Adds JSON dump/compare for instance segmentation and centralizes contour comparison logic.
model_api/tests/accuracy/public_scope.json Updates stored accuracy references for instance segmentation to the new structured format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread model_api/tests/accuracy/test_accuracy.py
Comment thread model_api/tests/accuracy/test_accuracy.py
Comment thread model_api/tests/accuracy/test_accuracy.py
@tybulewicz
tybulewicz enabled auto-merge June 26, 2026 12:17
@tybulewicz
tybulewicz added this pull request to the merge queue Jun 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@tybulewicz
tybulewicz added this pull request to the merge queue Jun 29, 2026
Merged via the queue into master with commit 277bd82 Jun 29, 2026
34 checks passed
@tybulewicz
tybulewicz deleted the ttybulew/test_instance_segmentation_results branch June 29, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store InstanceSegmentation Models result in native format

3 participants