test: runtime module coverage (#328)#371
Merged
Merged
Conversation
Cover the previously-untested pure/adapter surfaces of the runtime: - core: event-marker, csr barrel, dsd-hydration, render-dsd-stream - element: open-element-render (light/shadow adapters), open-element-hydration - ssg: postprocess (inject*/build* helpers), route-scanner-fs (safe* IO) Uses structural FakeScope/FakeElement stand-ins so control-flow paths that do not require a real DOM are pinned without pulling in a DOM shim. ssg-dynamic remains covered by the existing ssg-render suite. Co-Authored-By: Senior Developer <dev@openelement.local>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
APIError: Insufficient Balance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit-test coverage for the runtime modules flagged in #328 as previously
untested pure/adapter surfaces.
event-marker(id/context/type parsing/serialize),csrbarrelre-export smoke test,
dsd-hydration(root attach/reuse, event hydratebind/abort),
render-dsd-stream(metrics collector lifecycle).open-element-render(light/shadow adapters, error fallback),open-element-hydration(early-return + reset/hydrate) using structuralFakeScope/FakeElementstand-ins (matchingOpenElementLike).postprocess(insertAfterHead, buildIslandChunkMap, injectClientScript,injectCspMeta escaping, injectDsdPolyfill, injectViewTransitionMeta,
injectSpeculationRules, buildSpeculationRulesJson explicit + two-tier
heuristic),
route-scanner-fs(safeReadFile/safeReadDir/safeStat success +missing branches).
ssg-dynamicremains covered by the existingssg-rendersuite, so the full#328 module list is now covered.
Test plan
deno teston all 8 new files: 51 passed.deno lint+deno fmt --checkclean on all 8.customElements-gated paths untouched.Closes #328