Conversation
Both example pages opened with narrative before showing anything runnable, and neither showed how the raw data becomes the parsed output. Restructure both to the same shape: Quick start, pipeline diagram, worked row, parser steps, regeneration and outputs. Correct four inaccurate claims, on unit resolution, currency form, schema output paths and the worked row index.
euronion
left a comment
There was a problem hiding this comment.
Thanks @cdgaete ! I really like the mermaid graphs. I'll steal this idea for other projects :)
Reading through this, it feels very dry and descriptive. I was wondering what your intended target audience is? First-time users or people looking into a documentation for a specific parser?
If it is the former (first time users), it seems a bit too detailed, e.g. the specific opinioated transformations that are being made.
If it is the second (documentation on the parsers), it feels a bit too simple / shallow. E.g. the intial examples on how to use it would not need to be repeated, instead it might make sense to include some more specific information about the data, like which technologies are covered, opinioated transformations, ...?
What's your take? Could you elaborate a bit more your target audience?
|
ping @cdgaete |
|
Hi @euronion, thanks for the review! The intended audience is first-time users. I see your point — some parts, like the opinionated transformations, are probably too detailed for that. But I'd argue energy modelers usually have a solid background, so the extra depth still serves them rather than overwhelming them. For now, I'd prefer to leave it as is rather than simplify. That said, if you think trimming would help, I'm happy to get concrete guidelines on what to remove or restructure, and implement those. |
Closes #107
Changes proposed in this Pull Request
Both example pages —
docs/examples/dea_storage_v10.mdanddocs/examples/manual_input_usa_v0134.md— opened with an Overview, a Dataset Description and a step-by-step Parser description, so the first runnable line appeared around line 75. Neither showed how the raw data becomes the parsed output.Each page is restructured to the same shape, with the first snippet now at line 21:
load()snippets with their captured output: the number of technologies, the collection as a dataframe, and one parameter of one technology.Technology.parse()snippet and its parameters, unchanged in substance.Every code block was executed against a clean install of the built wheel from a working directory outside the repository; the
textblocks are the captured output.Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.