Skip to content

fix(generator): dotnet dependency injection issue #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 2 commits into from
Feb 6, 2026
Merged

fix(generator): dotnet dependency injection issue #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f3193b
fix(208): explicitly register interface for FeatureClient in DI
tomflenner Feb 5, 2026
af0907a
test(208): enforce the usage of extension method
tomflenner Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/cmd/testdata/success_csharp.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace TestNamespace
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<GeneratedClient>();
}

Expand All @@ -55,7 +55,7 @@ namespace TestNamespace
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<GeneratedClient>();
}
}
Expand Down
4 changes: 2 additions & 2 deletions internal/generators/csharp/csharp.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace {{ if .Params.Custom.Namespace }}{{ .Params.Custom.Namespace }}{{ else
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<GeneratedClient>();
}

Expand All @@ -49,7 +49,7 @@ namespace {{ if .Params.Custom.Namespace }}{{ .Params.Custom.Namespace }}{{ else
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<GeneratedClient>();
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/csharp-integration/OpenFeature.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<GeneratedClient>();
}

Expand All @@ -55,7 +55,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<GeneratedClient>();
}
}
Expand Down
7 changes: 3 additions & 4 deletions test/csharp-integration/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ static void Main(string[] args)

// Test DI initialization
var services = new ServiceCollection();
// Register OpenFeature services manually for the test
services.AddSingleton(_ => Api.Instance);
services.AddSingleton<IFeatureClient>(_ => Api.Instance.GetClient());
services.AddSingleton<GeneratedClient>();

services.AddOpenFeature();

var serviceProvider = services.BuildServiceProvider();

// Test client retrieval from DI
Expand Down
4 changes: 2 additions & 2 deletions test/csharp-integration/expected/OpenFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<GeneratedClient>();
}

Expand All @@ -39,7 +39,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<GeneratedClient>();
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/csharp-integration/expected/OpenFeature.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient())
.AddSingleton<GeneratedClient>();
}

Expand All @@ -38,7 +38,7 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
{
return services
.AddSingleton(_ => Api.Instance)
.AddSingleton(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<IFeatureClient, FeatureClient>(provider => provider.GetRequiredService<Api>().GetClient(domain))
.AddSingleton<GeneratedClient>();
}
}
Expand Down
Loading