-
Notifications
You must be signed in to change notification settings - Fork 65
feat(flagd): introduce fatalStatusCodes option #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leakonvalinka
wants to merge
16
commits into
open-feature:main
Choose a base branch
from
open-feature-forking:fix/flagd-infinite-connection-retries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+222
−80
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8b7f574
fix(flagd): no retry for certain error codes, implement test steps
leakonvalinka f0a1db2
attempt to handle fatal error
leakonvalinka 654c8da
fix(flagd): update testbed + step, fix event
leakonvalinka 07195a7
adjust rpc resolver
leakonvalinka ccf5120
Merge branch 'main' into fix/flagd-infinite-connection-retries
leakonvalinka e6d4057
fix e2e tests
leakonvalinka 75392e6
Merge branch 'main' into fix/flagd-infinite-connection-retries
leakonvalinka 95a880c
clean up
leakonvalinka 45a9822
fatal only on first connection
leakonvalinka e50aa7f
remove exclusion of sync e2e test tag
leakonvalinka a636257
add shutdown after fatal, fix tests
leakonvalinka 5794b1a
Merge branch 'main' into fix/flagd-infinite-connection-retries
leakonvalinka d27e4e9
remove shutdown
leakonvalinka 94c7691
fix lint issues
leakonvalinka ee42405
fix spotless
leakonvalinka 02539d0
feat(flagd): Communicate Fatal and shutdown connectors
guidobrei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
...n/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/StorageState.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| package dev.openfeature.contrib.providers.flagd.resolver.process.storage; | ||
|
|
||
| /** Satus of the storage. */ | ||
| /** Status of the storage. */ | ||
| public enum StorageState { | ||
| /** Storage is upto date and working as expected. */ | ||
| OK, | ||
| /** Storage has gone stale(most recent sync failed). May get to OK status with next sync. */ | ||
| STALE, | ||
| /** Storage has gone stale (most recent sync failed). May get to OK status with next sync. */ | ||
| TRANSIENT_ERROR, | ||
| /** Storage is in an unrecoverable error stage. */ | ||
| ERROR, | ||
| FATAL_ERROR, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,6 @@ | |
| /** Payload type emitted by {@link QueueSource}. */ | ||
| public enum QueuePayloadType { | ||
| DATA, | ||
| ERROR | ||
| ERROR, | ||
| SHUTDOWN | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should print an info/warn that the env vars are invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for this method? Or the other ones too? I'd either leave it or add it in all cases to be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should add it everywhere, but in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, sounds good. Should we create a new issue for this or is that overkill?