🐛 [open-formulieren/open-forms#5435] skip validation for hidden selectboxes#2
Closed
annashamray wants to merge 1 commit into
Closed
🐛 [open-formulieren/open-forms#5435] skip validation for hidden selectboxes#2annashamray wants to merge 1 commit into
annashamray wants to merge 1 commit into
Conversation
…if it's not visible
Author
|
It will be fixed in open-forms-sdk repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes open-formulieren/open-forms#5435
Explanation:
When
selectboxescomponents is placed inside a hidden fieldset then it has propertiesconditionallyVisible= true butvisible= false.In the
SelectBoxes.checkComponentValiditymethodisValidmethod is called, which callsValidator.validate, which usesconditionallyVisibleproperty. Therefore we have invisible but invalid component.The validation should be skipped in this case, so
shouldSkipValidationis added beforeisValid