Skip to content

[#3535] Fix pausing form allows navigating to next step#5666

Draft
vaszig wants to merge 1 commit into
mainfrom
fix/3535-pausing-a-form-allows-clicking-next-disabled-step
Draft

[#3535] Fix pausing form allows navigating to next step#5666
vaszig wants to merge 1 commit into
mainfrom
fix/3535-pausing-a-form-allows-clicking-next-disabled-step

Conversation

@vaszig
Copy link
Copy Markdown
Contributor

@vaszig vaszig commented Oct 2, 2025

Closes #3535

Changes

  • Do not always mark a submission step as completed (now even if a form is paused the submission step is saved so the backend treats this as a completed step). This allows the user to navigate to the next step (which in a regular submission is not allowed). OF though can prevent the user from "forgetting" to provide data for a required field in a previous step (we show validation errors).

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft October 2, 2025 12:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (59038e2) to head (b60f3d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5666   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         836      836           
  Lines       29953    29953           
  Branches     3875     3875           
=======================================
  Hits        29051    29051           
  Misses        609      609           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaszig vaszig force-pushed the fix/3535-pausing-a-form-allows-clicking-next-disabled-step branch from b60f3d6 to d2127a5 Compare October 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pausing a form allows user to click next step, even if progress is blocked

1 participant