Fix crash in logic rule when it contains a property action that refers to a non-existing component#6267
Merged
Merged
Conversation
…ers to a non-existing component When a rule contains a component that doesn't exist - this is still possible unfortunately because no validation is performed - the rule crashes in the admin. By adding a ? we can avoid a crash
viktorvanwijk
added
the
needs-backport
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6267 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 872 872
Lines 33122 33122
Branches 2990 2990
=======================================
Hits 32155 32155
Misses 652 652
Partials 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annashamray
approved these changes
May 8, 2026
| const intl = useIntl(); | ||
| const isLayout = action.component | ||
| ? holdsSubmissionDataTypes.includes(components[action.component].type) | ||
| ? holdsSubmissionDataTypes.includes(components[action.component]?.type) |
Contributor
There was a problem hiding this comment.
Oh! I didn't think of this possibility when added this line
viktorvanwijk
added a commit
that referenced
this pull request
May 8, 2026
…ers to a non-existing component When a rule contains a component that doesn't exist - this is still possible unfortunately because no validation is performed - the rule crashes in the admin. By adding a ? we can avoid a crash Backport of: #6267
Contributor
Author
Contributor
|
@viktorvanwijk No one asked for it and there was no "backport" label so... |
Contributor
Author
|
Yeah I see, just wondering if there should have been one 😅 Usually bugs get backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on #6261
[skip: e2e]
Changes
Added a question mark
Checklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene
Documentation