Create digital address for betrokkene in Customer Interactions API

[annashamray]

Closes #6082

Changes

• create a new digital address linked to "betrokkene" in Open Klant when
  • user selects existing address from dropdown
  • this is not a default address
  • they don't change the default preference (don't select "Sla mijn gegevens op
    voor de volgende keer.")

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Checked new model fields are usable in the admin
  • Problem detection in the admin email digest is handled

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

• Documentation

  • Added documentation which describes the changes

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (d1c4275) to head (b54734b).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6280      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.01%     
==========================================
  Files         872      866       -6     
  Lines       33122    32760     -362     
  Branches     2990     2982       -8     
==========================================
- Hits        32155    31802     -353     
+ Misses        652      646       -6     
+ Partials      315      312       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[robinmolen]

I have a few small suggestions, but otherwise this looks good!

[robinmolen]

I had some difficulty trying to understand this condition (mostly because i wasn't sure what prefill_preferred was, as i forgot what the property preferred on the CommunicationChannel represented).

Because we have the same check for flow 5, it might be nice to define a is_preferred variable.

So:

is_preferred_address: bool = bool(address_value == prefill_preferred)

...

# flow 3. we create a new address and link it to betrokkene
elif not is_address_new_preferred and not is_preferred_address:

Bonus: in the type definition of CommunicationChannel it might be nice to add a comment what the property preferred contains. Something like:

class CommunicationChannel(TypedDict):
    type: SupportedChannels
    options: Sequence[str]
    preferred: str | None # The preferred address in this channel

[annashamray]

Yes, I think with these changes the code is more readable. I also changed if statements, I couldn't get rid of nested "ifs", but I think now is clearer what happens in each flow

[sergei-maertens]

Suggested change

	is_preferred_address: bool = bool(address_value == prefill_preferred)
	is_preferred_address = address_value == prefill_preferred

the cast to bool is not necesary for a simple equality test

[annashamray]

changed

processed