Add oids mappings with objects names#359
Merged
andr-sokolov merged 8 commits intoOPENGPDB_STABLEfrom Mar 6, 2026
Merged
Conversation
NJrslv
requested changes
Mar 5, 2026
NJrslv
approved these changes
Mar 6, 2026
andr-sokolov
added a commit
that referenced
this pull request
Mar 6, 2026
It is necessary to know names of tables and functions used in a query, but AST contains oids only. We cannot use the system catalog tables to find out the names, because tables and functions may have been dropped before the logs are analysed. Append oids mappings with names of relations and functions to AST. These mappings also contain list of columns to get column name by its index. The nodeToString function is replaced with query_to_text. This new function finds out relations and functions oids in the Query structure. If they exist, the function appends records about them to the output of nodeToString. Otherwise, query_to_text return value is the same as that of nodeToString.
andr-sokolov
added a commit
that referenced
this pull request
Mar 6, 2026
It is necessary to know names of tables and functions used in a query, but AST contains oids only. We cannot use the system catalog tables to find out the names, because tables and functions may have been dropped before the logs are analysed. Append oids mappings with names of relations and functions to AST. These mappings also contain list of columns to get column name by its index. The nodeToString function is replaced with query_to_text. This new function finds out relations and functions oids in the Query structure. If they exist, the function appends records about them to the output of nodeToString. Otherwise, query_to_text return value is the same as that of nodeToString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is necessary to know names of tables and functions used in a query, but AST
contains oids only. We cannot use the system catalog tables to find out
the names, because tables and functions may have been dropped before the logs
are analysed.
Append oids mappings with names of relations and functions to AST. These
mappings also contain list of columns to get column name by its index.
The nodeToString function is replaced with query_to_text. This new function
finds out relations and functions oids in the Query structure. If they exist,
the function appends records about them to the output of nodeToString.
Otherwise, query_to_text return value is the same as that of nodeToString.