Fix trusted npm latest release path#55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Changes production npm release sequencing and trusted vs token paths; mistakes could block releases or publish at the wrong stage, but scope is limited to CI workflow logic.
Overview
Reworks the latest channel path when
publish_authis trusted so the version is not published to@devbefore production approval.prerelease-publishis skipped for trusted, non–dry-run latest runs. A newtrusted-latest-checkjob runs the same pre-publish gates (release tag, GitHub release assets,npm test/build,npm pack --dry-run) without touching the registry.prod-release-planandprod-releasenow advance when eithertrusted-latest-checkorprerelease-verifysucceeds; the production version is taken fromrelease-input, not the prerelease job. Inprod-release, trusted mode performs a single OIDCnpm publish --tag latestafter theprodenvironment; token mode keepsnpm dist-tag addpromotion only, with token verification steps gated topublish_auth=token.Workflow input descriptions are updated to match this behavior.
Reviewed by Cursor Bugbot for commit 5c83b0b. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.