Skip to content

Implementing CI#216

Merged
guoguojenna merged 9 commits into
open-iscsi:masterfrom
guoguojenna:617-ci
Sep 26, 2025
Merged

Implementing CI#216
guoguojenna merged 9 commits into
open-iscsi:masterfrom
guoguojenna:617-ci

Conversation

@guoguojenna
Copy link
Copy Markdown
Collaborator

@guoguojenna guoguojenna commented Jun 23, 2025

This pull request adds packaging and continuous integration (CI) support for targetcli-fb project.

1. Packaging and Testing

  • Added: .packit.yaml
    Sets up Packit for Fedora/EPEL integration, to automates COPR builds and testing for PRs.
  • Added: fedora/python-targetcli-fb.spec
    Provides a Fedora RPM spec file for building and packaging the project, including subpackages and systemd integration.
  • Added: ci-tests/sts.fmf and .fmf/version
    Adds a Flexible Metadata Format (FMF) test plan which defines the real functional test suite it will be run
  • Packit will be triggered in the following situations:
    • When a pull request is opened or updated, Packit will:
      • Build your package in COPR for the targets fedora-latest-stable and epel-9.
      • Run tests for the targets fedora-latest-stable and epel-9.
      • The real functional tests are run by testing-farm.
    • When a new release is created in your upstream repository, Packit will propose downstream updates (sync your changes) to the Fedora and EPEL dist-git branches for fedora-latest-stable and epel-9.

2. CodeQL Security Scanning
Added: .github/workflows/codeql.yml
Introduces CodeQL analysis, and automates security and quality checks via GitHub Actions.
It is triggered on events like push, pull_request.

3. Pre-commit Configuration

  • Updates the ruff-pre-commit hook from v0.4.2 to v0.11.13.
  • Updates the pre-commit-hooks hook from v4.6.0 to v5.0.0.
  • Cleans up duplicate hooks and improves configuration.
  • Adds packit/pre-commit-hooks for config validation.
  • Introduces pre-commit.ci
  • It's triggered on Pull Request creation/updates

In summary, Status Checks Required
pre-commit.ci status, Code style and quality
CodeQL security checks, Security scanning
Packit COPR builds, RPM packaging and builds
Testing Farm results, Integration testing

This PR prepares targetcli-fb for Fedora/EPEL packaging and improves automation/testing workflows. It can automatically builds and tests code changes, enabling early bug detection and ensuring higher code quality with faster feedback.

@guoguojenna
Copy link
Copy Markdown
Collaborator Author

guoguojenna commented Jun 23, 2025

Note:

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@guoguojenna
Copy link
Copy Markdown
Collaborator Author

CI tests failed with issue and

FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.CompareAndWrite]
FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.ReceiveCopyResults]
FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.iSCSIResiduals.Write1*]
======== 3 failed, 60 passed, 1 xfailed, 1 xpassed in 86.39s (0:01:26) =========

https://artifacts.dev.testing-farm.io/57f247dd-6827-4a31-a059-fffc00a5af7f/

@guoguojenna guoguojenna merged commit a59b5ee into open-iscsi:master Sep 26, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants