feat(core-spec): add semantic_model.behavior with actions/effects#105
Open
zljie wants to merge 1 commit into
Open
feat(core-spec): add semantic_model.behavior with actions/effects#105zljie wants to merge 1 commit into
zljie wants to merge 1 commit into
Conversation
jbonofre
reviewed
Apr 29, 2026
Collaborator
jbonofre
left a comment
There was a problem hiding this comment.
Can you please clarify between behavior-layer.schema.json and osi-schema.json?
| "required": ["vendor_name", "data"], | ||
| "additionalProperties": false | ||
| }, | ||
| "Behavior": { |
Collaborator
There was a problem hiding this comment.
I'm a bit confused here: it seems we have two behavior type definition:
- in
behavior-layer.schema.jsonwith standalone schema - in
osi-schema.jsoninline as$defs/Behavior,$defs/BehaviorAction,$defs/BehaviorEffect,$defs/BehaviorRule
I see already some differences before the two definitions.
Why not having osi-schema.json reference behavior-layer.schema.json via $ref.
I guess that having two schemas that must kept in sync manually will drift.
| "properties": { | ||
| "entity": { "type": "string", "enum": ["dataset", "field", "metric", "relationship"] }, | ||
| "mode": { "type": "string", "enum": ["read", "write", "derive"] }, | ||
| "impact_type": { "type": "string" }, |
Collaborator
There was a problem hiding this comment.
impact_type is a string here, but an implicit enum in spec.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: feat(core-spec): add
semantic_model.behaviorwith actions/effects (aliasaction_types)What
This PR adds an optional, vendor-agnostic first-class behavior block to OSI Core:
semantic_model.behaviorbehavior.actions(preferred) with legacy aliasbehavior.action_typesaction.effectsfor machine-readable impact annotations (what a behavior reads/writes/derives)Why
Many agent-driven workflows require deterministic action planning and attribution:
Embedding behavior under
custom_extensionsworks but is not easily discoverable/validatable by generic tooling. Promoting a standard first-class block improves interoperability while preserving extensibility.Backwards compatibility
semantic_model.behavioris optional (additive change).custom_extensions.behavior,actionsis preferred;action_typesremains a supported alias.Validation
Local validation passed using
validation/validate.py:examples/p2p_behavior_effects_minimal.yamlexamples/tpcds_semantic_model.yamlFiles changed
core-spec/spec.yamlcore-spec/spec.mdcore-spec/osi-schema.jsoncore-spec/behavior-layer.schema.json(new)core-spec/behavior-layer.md(new)examples/p2p_behavior_effects_minimal.yaml(new)examples/tpcds_semantic_model.yaml(version bump)Example included
Minimal SAP P2P example:
suppliers/blockandsuppliers/unblockactionssuppliers.status