Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to documentation/comment URL updates and are consistent across the spec and proto without affecting behavior.
Pull request overview
Updates references to the GnuPG manual for “detached signature”/GPG signing to match the new GnuPG documentation URL layout (single manual.html page with anchors).
Changes:
- Update the detached signature link in
specification.mdto the new GnuPG manual URL/anchor. - Update the corresponding comment link in
proto/opamp/v1/opamp.prototo keep the proto docs consistent with the spec.
File summaries
| File | Description |
|---|---|
| specification.md | Updates two documentation links to the new GnuPG manual anchor for detached signatures/GPG signing. |
| proto/opamp/v1/opamp.proto | Updates the proto field comment link to match the spec’s updated GnuPG manual reference. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnupg changed the layout of the pages. It includes anchor within the pages. 160--->161 is intentional