Activity rule impl #127
Merged
Activity rule impl #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
alex-tiurin
reviewed
Oct 25, 2025
...ommon/src/androidMain/kotlin/com/atiurin/ultron/testlifecycle/activity/UltronActivityRule.kt
Show resolved
Hide resolved
| counter = -1, | ||
| key = "LAUNCH ACTIVITY", | ||
| name = "SetUp 'launch activity'", | ||
| actions = { scenario = scenarioSupplier.get() } |
Collaborator
There was a problem hiding this comment.
actions = { scenario = scenarioSupplier.get() }
replace with
actions = { launchActivity() }
...mpose/src/androidMain/kotlin/com/atiurin/ultron/core/compose/ComposeRuleContainer.android.kt
Show resolved
Hide resolved
alex-tiurin
reviewed
Oct 25, 2025
...ommon/src/androidMain/kotlin/com/atiurin/ultron/testlifecycle/activity/UltronActivityRule.kt
Outdated
Show resolved
Hide resolved
dabrynskiy
force-pushed
the
activity-rule-impl
branch
from
eaa1ff4 to
3f43d8c
Compare
alex-tiurin
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem:
Teardown from rule
androidx.test.ext.junit.rules.ActivityScenarioRulewaits for idle state before destroing activity.In case of AppNotIdle exception error this results in infinite test execution.
In order to reproduce the problem in sample-app the activity
BusyActivitywas added, a test was added that launches this activitycom.atiurin.sampleapp.tests.espresso.UltronActivityRuleTest#appNotIdleChanges:
Added rule
com.atiurin.ultron.testlifecycle.activity.UltronActivityRule- is a reduced copy fromandroidx.test.ext.junit.rules.ActivityScenarioRule.com.atiurin.ultron.testlifecycle.activity.UltronActivityRulefinishing all activities in the RESUMED, PAUSED, STOPPED stage without wait idle state