feat: add Windows x64 (MSVC) platform support#202
Open
br-to wants to merge 4 commits into
Open
Conversation
Add x86_64-pc-windows-msvc target to CI/CD build matrix and npm distribution so that `npm install @open-wallet-standard/core` works on Windows without the "Cannot find module core-win32-x64-msvc" error. Closes open-wallet-standard#136 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@br-to is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
I'm running into the same issue. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hi @njdawn, would you mind taking a look at this PR when you have a chance? Happy to address any feedback! |
|
Would love if this was merged also as finding it hard to develop on Windows currently. Windows platform support would increase developer adoption. |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
x86_64-pc-windows-msvctarget across the entire build and distribution pipeline so thatnpm install @open-wallet-standard/coreworks on Windows x64 without theCannot find module '@open-wallet-standard/core-win32-x64-msvc'error.Currently the
optionalDependenciesinpackage.jsonand the CI build matrix only include macOS and Linux targets. Windows users hit a hard failure at runtime because the platform-specific npm package (core-win32-x64-msvc) is never built or published.Changes
bindings/node/npm/win32-x64-msvc/package.json— new platform package for Windows x64 (mirrors existing darwin/linux packages)bindings/node/package.json— addx86_64-pc-windows-msvcto napi triples and@open-wallet-standard/core-win32-x64-msvcto optionalDependenciesbindings/node/bin/ows— addwin32-x64entry toPLATFORM_MAP(resolves toows.exe).github/workflows/release.yml— addwindows-latestto build matrix for:buildjob)node-addonsjob)python-wheelsjob)publish-npmjob).exeextension in rename/upload stepsshell: bashfor set-version.sh on Windows runnersPlatform matrix (after this PR)
core-darwin-arm64aarch64-apple-darwinmacos-latestcore-darwin-x64x86_64-apple-darwinmacos-latestcore-linux-x64-gnux86_64-unknown-linux-gnuubuntu-latestcore-linux-arm64-gnuaarch64-unknown-linux-gnuubuntu-latestcore-win32-x64-msvcx86_64-pc-windows-msvcwindows-latestCloses #136
Test plan
windows-latestfor all three jobs (build, node-addons, python-wheels)npx napi build --platform --release --target x86_64-pc-windows-msvcproducesows-node.win32-x64-msvc.nodecargo build --release --target x86_64-pc-windows-msvcproducesows.exeinows/workspacenpm install @open-wallet-standard/coreon Windows x64 resolvescore-win32-x64-msvcwithout errorsowsCLI launches correctly on Windows via the Node.js bin wrapper🤖 Generated with Claude Code
Note
Medium Risk
Medium risk due to changes across the release workflow matrices and artifact naming/packaging, which could break cross-platform builds or publishing if Windows-specific paths/shell behavior differs.
Overview
Adds Windows x64 (MSVC) support across the release pipeline so binaries and language bindings are built and published for
x86_64-pc-windows-msvc.Updates
.github/workflows/release.ymlto include Windows runners in the CLI, Node addon, and Python wheel matrices, with Windows-specific.exerenaming/upload andshell: bashwhereset-version.shis invoked.Extends the Node distribution to ship a Windows platform package: adds
@open-wallet-standard/core-win32-x64-msvc(newnpm/win32-x64-msvc/package.json), wires it intobindings/node/package.json(napitriples +optionalDependencies), updates thebindings/node/bin/owswrapper to resolvewin32-x64toows.exe, and copies the Windows CLI binary into the Windows npm package during publish.Reviewed by Cursor Bugbot for commit 74bdac6. Bugbot is set up for automated code reviews on this repo. Configure here.