feat: add solana kit adapter#215
Open
beeman wants to merge 1 commit into
Open
Conversation
Add a new solana-kit subpath export that returns a Kit KeyPairSigner from an exported OWS ed25519 key. Cover the adapter with dedicated tests and document the new install and usage flow in the adapters README.
|
@beeman is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a new solana-kit subpath export that returns a Kit KeyPairSigner from an exported OWS ed25519 key.
Cover the adapter with dedicated tests and document the new install and usage flow in the adapters README.
Why
I want to use OWS with a @solana/kit app and it would be great if it's natively supported.
Closes #
Testing
cargo test --workspacepassescargo clippy --workspace -- -D warningsis cleannpm testpasses (if Node bindings changed)owsCLINotes
If you'd like to see any changes, please let me know.
I thought for consistency it may be good to rename the existing
solanaoption tosolana-web3jsbut that would probably be a breaking change and a different PR.